Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mithril-client-wasm tests in multi platform test #1462

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Add mithril-client-wasm tests in multi platform test #1462

merged 4 commits into from
Jan 31, 2024
+4,713 −1

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 25, 2024 •
edited
Loading

Content

This PR includes tests implementation for mithril-client-wasm. This tests are executed in headless mode with Google Chrome and Firefox from the manual workflow Mithril Client multi-platform test.

Two scripts were added:

  • run-wasm-tests-browser-headless.py: call by the manual workflow to run browsers in headless mode and save the output to a html file with the test results. It takes the browser as argument (chrome or firefox).
  • parse-wasm-headless-tests-results.sh: call by the manual workflow to handle both browsers test results

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Close to #1408

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

Test Results

  3 files  ±0   33 suites  ±0   8m 38s ⏱️ -5s
787 tests ±0  787 ✅ ±0  0 💤 ±0  0 ❌ ±0 
860 runs  ±0  860 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 153c91f. ± Comparison against base commit ec8910b.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from 03eb494 to 2607e08 Compare January 25, 2024 19:07
@dlachaume dlachaume self-assigned this Jan 25, 2024
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from 2607e08 to fd2f570 Compare January 26, 2024 10:00
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from fd2f570 to 57ae8b8 Compare January 26, 2024 10:30
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch 2 times, most recently from b872daf to c24c6b7 Compare January 26, 2024 11:30
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from c24c6b7 to 4e1f074 Compare January 26, 2024 13:17
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from 4e1f074 to fcdcd96 Compare January 26, 2024 13:34
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from fcdcd96 to b67b12c Compare January 26, 2024 13:44
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from b67b12c to a1e904b Compare January 26, 2024 14:01
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from a1e904b to c471b15 Compare January 26, 2024 14:39
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from c471b15 to 7eb9030 Compare January 26, 2024 15:25
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from 7eb9030 to b9bed55 Compare January 26, 2024 15:42
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch 2 times, most recently from 10b7996 to 32935ca Compare January 26, 2024 16:19
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from aebf4c9 to 61a12e2 Compare January 30, 2024 11:37
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch 2 times, most recently from 862c69b to 98c081c Compare January 30, 2024 12:36
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch 2 times, most recently from 1008025 to c35fe18 Compare January 30, 2024 12:54
@dlachaume dlachaume marked this pull request as ready for review January 30, 2024 13:09
@dlachaume dlachaume requested review from jpraynaud and Alenar January 30, 2024 13:09
Alenar
Alenar reviewed Jan 30, 2024
View reviewed changes
mithril-client-wasm/www-test/package.json Outdated Show resolved Hide resolved
mithril-client-wasm/www-test/index.js Show resolved Hide resolved
mithril-client-wasm/www-test/index.js Outdated Show resolved Hide resolved
mithril-client-wasm/www-test/.bin/create-wasm-app.js Outdated Show resolved Hide resolved
@dlachaume
test: add tests for mithril-client-wasm
986da25 
These tests are intended to be performed in `Mithril Client multi-platform test`
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch 2 times, most recently from 7d1aba7 to 0e34a11 Compare January 30, 2024 16:46
jpraynaud
jpraynaud approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from 0e34a11 to 8ad97c9 Compare January 30, 2024 16:57
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from 06a209d to 795218f Compare January 31, 2024 09:43
@dlachaume dlachaume force-pushed the damien/1408/add-wasm-tests-in-multi-platform-test branch from 795218f to 153c91f Compare January 31, 2024 09:56
@dlachaume dlachaume merged commit beb0042 into main Jan 31, 2024
54 checks passed
@dlachaume dlachaume deleted the damien/1408/add-wasm-tests-in-multi-platform-test branch January 31, 2024 10:30
@jpraynaud jpraynaud linked an issue Jan 31, 2024 that may be closed by this pull request
Add WASM client step in Mithril Client multi-platform test #1408
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add WASM client step in Mithril Client multi-platform test
3 participants
@dlachaume @Alenar @jpraynaud